-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Move keyctl to new/linux_uapi #4725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These constants are entirely defined in the Linux UAPI. https://elixir.bootlin.com/linux/v6.16.9/source/include/uapi/linux/keyctl.h
| target_arch = "mips32r6", | ||
| target_arch = "mips64", | ||
| target_arch = "mips64r6" | ||
| )))] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why glibc and MIPS were special-cased here. In theory, that should not be necessary for constants defined in the Linux UAPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this was wrong and it's good that it's being removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, LGTM!
These constants are entirely defined in the Linux UAPI. https://elixir.bootlin.com/linux/v6.16.9/source/include/uapi/linux/keyctl.h (backport <rust-lang#4725>) (cherry picked from commit 2bf1f66)
These constants are entirely defined in the Linux UAPI. https://elixir.bootlin.com/linux/v6.16.9/source/include/uapi/linux/keyctl.h (backport <rust-lang#4725>) (cherry picked from commit 2bf1f66)
These constants are entirely defined in the Linux UAPI. https://elixir.bootlin.com/linux/v6.16.9/source/include/uapi/linux/keyctl.h (backport <#4725>) (cherry picked from commit 2bf1f66)
Description
These constants are entirely defined in the Linux UAPI.
cc @tgross35 @Gelbpunkt
Sources
Checklist
Relevant tests inno changelibc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI